Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HttpClientInstrumentationOptions #5109

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Dec 1, 2023

Fixes #
Design discussion issue #

Changes

Renaming the class to make the intent more clear. It keeps the option to introduce metric options separately in future (if needed).

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review December 1, 2023 02:34
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner December 1, 2023 02:34
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #5109 (28d78b9) into main (f592dcf) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5109      +/-   ##
==========================================
- Coverage   83.10%   83.09%   -0.01%     
==========================================
  Files         296      296              
  Lines       12318    12318              
==========================================
- Hits        10237    10236       -1     
- Misses       2081     2082       +1     
Flag Coverage Δ
unittests 83.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Instrumentation.Http/HttpClientInstrumentation.cs 100.00% <100.00%> (ø)
...tion.Http/HttpClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...tp/Implementation/HttpHandlerDiagnosticListener.cs 71.75% <ø> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 82.15% <100.00%> (ø)
...umentation.Http/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants