Fix Console metric exporter null reference #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
==========================================
- Coverage 83.14% 82.91% -0.23%
==========================================
Files 296 296
Lines 12317 12318 +1
==========================================
- Hits 10241 10214 -27
- Misses 2076 2104 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
Nov 30, 2023
| @@ -75,12 +75,15 @@ public override ExportResult Export(in Batch<Metric> batch) | |||
|
|
|||
| this.WriteLine(msg.ToString()); | |||
|
|
|||
| foreach (var meterTag in metric.MeterTags) | |||
| if (metric.MeterTags != null) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes