Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtls] Deprecate *Context funcs #9945

Merged

Conversation

TylerHelmuth
Copy link
Member

Works towards #9811

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner April 11, 2024 20:46
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.77%. Comparing base (7469f38) to head (d5cb791).

Files Patch % Lines
config/configtls/configtls.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9945      +/-   ##
==========================================
- Coverage   91.80%   91.77%   -0.03%     
==========================================
  Files         358      358              
  Lines       16568    16568              
==========================================
- Hits        15210    15206       -4     
- Misses       1034     1038       +4     
  Partials      324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member Author

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@codeboten codeboten merged commit 282a594 into open-telemetry:main Apr 15, 2024
47 of 48 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 15, 2024
@TylerHelmuth TylerHelmuth deleted the configtls-depr-context-funcs branch April 15, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants