Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component] Reject component.IDs that are too long #9872

Closed
mx-psi opened this issue Apr 1, 2024 · 3 comments
Closed

[component] Reject component.IDs that are too long #9872

mx-psi opened this issue Apr 1, 2024 · 3 comments
Assignees
@ankitpatel96
Labels
area:component good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Apr 1, 2024

Follow up to #9208, proposed by @hughesjj at #9670 (comment).

While this is a breaking change I think we can make it in one go since it's likely to affect nobody.
@mx-psi mx-psi added release:required-for-ga Must be resolved before GA release area:component labels Apr 1, 2024
@TylerHelmuth TylerHelmuth added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels Apr 2, 2024
@atoulme
Copy link
Contributor

atoulme commented Apr 3, 2024

@hughesjj what would be the max length allowed?

@TylerHelmuth
Copy link
Member

k8s uses 63, thats good enough for me

@ankitpatel96
Copy link
Contributor

I can work on this!

@ankitpatel96 ankitpatel96 mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitpatel96 ankitpatel96

Labels
area:component good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/compone...
Development

No branches or pull requests
4 participants
@atoulme @mx-psi @ankitpatel96 @TylerHelmuth