[configgrpc] Add ToServerContext
#9624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9624 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 347 347
Lines 18344 18346 +2
=======================================
+ Hits 16681 16683 +2
Misses 1340 1340
Partials 323 323 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Feb 27, 2024
|
@TylerHelmuth please rebase |
TylerHelmuth
force-pushed
the
configgrpc-add-context
branch
from
9c987b2
to
31f5447
Compare
|
@dmitryax rebased |
dmitryax
approved these changes
Feb 29, 2024
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
codeboten
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new function,
ToServerContextwhich does whatToServerdoes, but takes acontext.Context. After the next release we'll deprecateToServerContextand rename it toToServer.Link to tracking Issue:
Related to #9490
Testing:
Unit tests
Documentation:
Please delete paragraphs that you did not use before submitting.