[mdatagen] Remove use of ReportFatalError in generated tests #9439
Conversation
atoulme
force-pushed
the
remove_assert_host
branch
from
451c710
to
8ee06bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9439 +/- ##
=======================================
Coverage 90.45% 90.45%
=======================================
Files 344 344
Lines 18024 18024
=======================================
Hits 16303 16303
Misses 1392 1392
Partials 329 329 ☔ View full report in Codecov by Sentry. |
| @@ -33,27 +32,6 @@ import ( | |||
| {{ end }} | |||
| ) | |||
|
|
|||
| // assertNoErrorHost implements a component.Host that asserts that there were no errors. | |||
There was a problem hiding this comment.
Should we instead generate an assert no error StatusReporter?
There was a problem hiding this comment.
I'd do it in phases. I am fairly certain that if we generate an assert no error StatusReporter, tests will fail because it's ok for them to report status errors on start if say we have no database to connect to.
I would also create this reporter in a common lib rather than in every generated test.
There was a problem hiding this comment.
I think we can assert if the status is fatal not on error.
atoulme
force-pushed
the
remove_assert_host
branch
from
8ee06bd
to
bf672e4
Compare
atoulme
force-pushed
the
remove_assert_host
branch
from
bf672e4
to
31ea28a
Compare
| @@ -33,27 +32,6 @@ import ( | |||
| {{ end }} | |||
| ) | |||
|
|
|||
| // assertNoErrorHost implements a component.Host that asserts that there were no errors. | |||
There was a problem hiding this comment.
I think we can assert if the status is fatal not on error.
Description:
Remove use of ReportFatalError in generated tests
Link to tracking Issue:
open-telemetry/opentelemetry-collector-contrib#30579