Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configcompression] make IsCompressed a member function #9435

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Updates IsCompressed to be a member function.

Link to tracking Issue:

Closes #9434

Testing:

Documentation:

Please delete paragraphs that you did not use before submitting.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f37e376) 90.24% compared to head (8cacfc9) 90.25%.
Report is 4 commits behind head on main.

Files Patch % Lines
config/configcompression/compressiontype.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9435      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         344      344              
  Lines       17932    17957      +25     
==========================================
+ Hits        16182    16207      +25     
  Misses       1421     1421              
  Partials      329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/configcompression/compressiontype.go Outdated Show resolved Hide resolved
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@dmitryax dmitryax merged commit 923cba6 into open-telemetry:main Feb 1, 2024
41 of 42 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
@TylerHelmuth TylerHelmuth deleted the configcompression-make-member-func branch February 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configcompression] make IsCompressed a member function
4 participants