Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config/configgrpc] Introduce new functions that use context.Context #9389

Closed
atoulme opened this issue Jan 25, 2024 · 1 comment
Closed

[config/configgrpc] Introduce new functions that use context.Context #9389

atoulme opened this issue Jan 25, 2024 · 1 comment
Labels
area:config
Milestone
go.opentelemetry....

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 25, 2024

Similar and building on #9105, we now can expose context in configgrprc ToListener.
@atoulme atoulme mentioned this issue Jan 25, 2024
Merged
codeboten pushed a commit that referenced this issue Jan 25, 2024
@atoulme
[config/configgrpc] introduce toListenerContext, deprecate toListener (…
3cacd40 
…#9390)

Introduce `ToListenerContext` and deprecate `ToListener`.

**Link to tracking Issue:**
#9389
@atoulme atoulme mentioned this issue Jan 25, 2024
Merged
dmitryax pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Jan 25, 2024
@atoulme
[chore] Update core and adopt ToListenerContext (#30780)
01af3c7 
**Description:**
Adopt `ToListenerContext` 

**Link to tracking Issue:**
See
open-telemetry/opentelemetry-collector#9389

---------

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@atoulme @cparkins
[chore] Update core and adopt ToListenerContext (open-telemetry#30780)
297953d 
**Description:**
Adopt `ToListenerContext` 

**Link to tracking Issue:**
See
open-telemetry/opentelemetry-collector#9389

---------

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this issue Feb 12, 2024
@atoulme @anthoai97
[chore] Update core and adopt ToListenerContext (open-telemetry#30780)
c6937b4 
**Description:**
Adopt `ToListenerContext` 

**Link to tracking Issue:**
See
open-telemetry/opentelemetry-collector#9389

---------

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
@TylerHelmuth
Copy link
Member

We are instead deciding on removing ToListener: #9481. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/config/...
Development

No branches or pull requests
2 participants
@atoulme @TylerHelmuth