Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace local dependencies for mdatagen, unblocks release action #9358

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Replace local dependencies for mdatagen, unblocks release action #9358

merged 1 commit into from
Jan 23, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu
Replace local dependencies for mdatagen, unblocks release action
c406e35 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team as a code owner January 23, 2024 21:24
codeboten
codeboten approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this to unblock the release... I'm not sure what the right way to address this is, but i'll re-open #9281

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7c380d) 90.25% compared to head (c406e35) 90.25%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9358   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         343      343           
  Lines       18003    18003           
=======================================
  Hits        16249    16249           
  Misses       1426     1426           
  Partials      328      328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jan 23, 2024
@bogdandrutu bogdandrutu merged commit 946dc24 into open-telemetry:main Jan 23, 2024
34 of 36 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 23, 2024
@mmynk mmynk mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdandrutu @codeboten