[chore] remove hostWrapper #9346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9346 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 341 340 -1
Lines 17986 17971 -15
==========================================
- Hits 16256 16241 -15
Misses 1407 1407
Partials 323 323 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 23, 2024
TylerHelmuth
pushed a commit
to TylerHelmuth/opentelemetry-collector
that referenced
this pull request
Jan 23, 2024
Remove `hostWrapper`. This internal class is only used for extensions to wrap a specific logger, but since we have deprecated `ReportFatalError`, we should no longer expect this function to be called anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
hostWrapper. This internal class is only used for extensions to wrap a specific logger, but since we have deprecatedReportFatalError, we should no longer expect this function to be called anyway.