[configopaque] Implement encoding.BinaryMarshaler interface for String #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9279 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.02%
==========================================
Files 341 340 -1
Lines 18308 17970 -338
==========================================
- Hits 16535 16234 -301
+ Misses 1437 1412 -25
+ Partials 336 324 -12 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Jan 15, 2024
TylerHelmuth
force-pushed
the
configopaque-implement-BinaryMarshaler
branch
from
32292d6
to
bb3aa4d
Compare
mx-psi
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
cc @bogdandrutu, will merge this by Friday morning EU time if there are no objections/the PR is not blocked. Please block if you need more time to think about this
atoulme
approved these changes
Jan 17, 2024
atoulme
reviewed
Jan 17, 2024
atoulme
reviewed
Jan 17, 2024
Co-authored-by: Antoine Toulme <antoine@toulme.name>
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector
that referenced
this pull request
Jan 23, 2024
open-telemetry#9279) **Description:** <Describe what has changed.> Implements the `encoding.BinaryMarshaler` interface for `String`. This prevents the situation `configopaque` -> `[]byte` -> `string` from leaking the `String` value. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#9272 **Testing:** Added unit test --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements the
encoding.BinaryMarshalerinterface forString. This prevents the situationconfigopaque->[]byte->stringfrom leaking theStringvalue.Link to tracking Issue:
Closes #9272
Testing:
Added unit test