deprecate To*CreateSettings methods in obsreporttest.TestTelemetry
#8501
+113
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
codeboten
force-pushed
the
codeboten/deprecate-obsreporttest
branch
from
f05c9db to
ecee0ec
Compare
dmitryax
reviewed
Sep 21, 2023
djaglowski
approved these changes
Sep 22, 2023
I was talking about |
These methods create an import cycle when trying to move obsreporttest to componenttest. Deprecating these methods will allow us to remove them in the next version and move the remaining code into componenttest Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/deprecate-obsreporttest
branch
from
ecee0ec to
70ff282
Compare
codeboten
changed the title
obsreporttest.TestTelemetry
dmitryax
approved these changes
Sep 22, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Sep 22, 2023
follow up on open-telemetry#8501. As per the suggestion, the code in NewCreateSettings is pretty small and not needed as a separate function. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
that referenced
this pull request
Sep 25, 2023
follow up on #8501. As per the suggestion, the code in NewCreateSettings is pretty small and not needed as a separate function. Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods create an import cycle when trying to move obsreporttest to
componenttest. Deprecating these methods will allow us to remove them in
the next version and move the remaining code into componenttest
Fixes #8492