Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ability to set cipher suite for OTLP receiver when running TLS #8105

Closed
bputt-e opened this issue Jul 18, 2023 · 0 comments · Fixed by #9168
Closed

Enable ability to set cipher suite for OTLP receiver when running TLS #8105

bputt-e opened this issue Jul 18, 2023 · 0 comments · Fixed by #9168
Assignees
@atoulme
Labels
area:config enhancement New feature or request

Comments

@bputt-e
Copy link

bputt-e commented Jul 18, 2023

Describe the solution you'd like
I would like the ability to specify which ciphers receivers (OTLP in this instance) can accept for configuring TLS. It's helpful that we can configure TLSv1.2 and TLSv1.3, but would be great if we can then limit what ciphers users can use when connecting to the receiver

Describe alternatives you've considered
Unless I'm mistaken, I don't see in the TLS config code for the OTEL collector the ability to specify TLS ciphers
@atoulme atoulme mentioned this issue Dec 21, 2023
Merged
@atoulme atoulme added the enhancement New feature or request label Dec 21, 2023
@atoulme atoulme self-assigned this Jan 8, 2024
codeboten pushed a commit that referenced this issue Jan 17, 2024
@atoulme
[configtls] support setting cipher suites (#9168)
c1599fe 
**Description:**
Add `cipher_suites` to configtls:
Users can specify a list of cipher suites to pick from. If left blank, a
safe default list is used.

**Link to tracking Issue:**
Fixes #8105

**Testing:**
Unit tests

**Documentation:**
godoc and README

---------

Co-authored-by: Alex Boten <aboten@lightstep.com>
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this issue Jan 23, 2024
@atoulme @TylerHelmuth
[configtls] support setting cipher suites (open-telemetry#9168)
0666507 
**Description:**
Add `cipher_suites` to configtls:
Users can specify a list of cipher suites to pick from. If left blank, a
safe default list is used.

**Link to tracking Issue:**
Fixes open-telemetry#8105

**Testing:**
Unit tests

**Documentation:**
godoc and README

---------

Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atoulme atoulme

Labels
area:config enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[configtls] support setting cipher suites atoulme/opentelemetry-collector
2 participants
@atoulme @bputt-e