Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprofile aggregation temporality constants #12253

Merged

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 3, 2025

This adds constants to more easily use the aggregation temporality enum in pprofile.

This behavior is very similar to how pmetrics handles those constants.
See https://pkg.go.dev/go.opentelemetry.io/collector/pdata/pmetric#pkg-constants

cc @rockdaboot

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dmathieu dmathieu marked this pull request as ready for review February 3, 2025 15:59
@dmathieu dmathieu requested review from mx-psi and a team as code owners February 3, 2025 15:59
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (ef5f34f) to head (b3dd393).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12253   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         466      467    +1     
  Lines       25586    25595    +9     
=======================================
+ Hits        23354    23363    +9     
  Misses       1816     1816           
  Partials      416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deviates from the protobuf, right? Is the intent to add it to the protobuf later?

@dmathieu
Copy link
Member Author

dmathieu commented Feb 3, 2025

Hmm how does this deviate from the protobuf? It's adding public definitions for protobuf enums that are otherwise private.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dmathieu dmathieu force-pushed the pprofile-aggregation-temporality branch from 780bc47 to 582e27c Compare February 4, 2025 08:46
@mx-psi
Copy link
Member

mx-psi commented Feb 4, 2025

Ah, I was not aware this is part of protobuf. Maybe "deviate" is not the right word; what I meant is that this was not generated code as it is the case in the metrics constants and I didn't understand why. Seems like it's all good now :)

@mx-psi
Copy link
Member

mx-psi commented Feb 5, 2025

Will merge this on Friday if there are no further comments

@mx-psi mx-psi added this pull request to the merge queue Feb 7, 2025
Merged via the queue into open-telemetry:main with commit 765e4a5 Feb 7, 2025
53 checks passed
@dmathieu dmathieu deleted the pprofile-aggregation-temporality branch February 7, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants