Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scrapercontroler more generic and move closer to the scraperreceiver #12103

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu force-pushed the generalize-scraper branch 2 times, most recently from 309685b to 259beb3 Compare January 16, 2025 20:25
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 90.83969% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (c56efd3) to head (3a20821).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/scraperhelper/controller.go 90.32% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12103      +/-   ##
==========================================
- Coverage   91.63%   91.60%   -0.03%     
==========================================
  Files         456      461       +5     
  Lines       24138    24698     +560     
==========================================
+ Hits        22118    22625     +507     
- Misses       1646     1691      +45     
- Partials      374      382       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu marked this pull request as ready for review January 16, 2025 21:41
@bogdandrutu bogdandrutu requested a review from a team as a code owner January 16, 2025 21:41
@bogdandrutu bogdandrutu requested a review from dmitryax January 16, 2025 21:41
@bogdandrutu bogdandrutu force-pushed the generalize-scraper branch 2 times, most recently from 3b01fd7 to 96b80f4 Compare January 16, 2025 22:05
…iver

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 17, 2025
Merged via the queue into open-telemetry:main with commit bdf3ce4 Jan 17, 2025
52 of 53 checks passed
@bogdandrutu bogdandrutu deleted the generalize-scraper branch January 17, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants