[chore] Deprecate the interface exporter.Request.Merge() #12012
Merged
+77
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
mx-psi,
dmathieu,
a team,
bogdandrutu and
dmitryax
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12012 +/- ##
==========================================
+ Coverage 91.66% 91.70% +0.03%
==========================================
Files 447 447
Lines 23741 23728 -13
==========================================
- Hits 21762 21759 -3
+ Misses 1607 1600 -7
+ Partials 372 369 -3 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 4, 2025
|
I think we need to mark this as a "breaking" change even if it is for experimental interface we still need to add a changelog. Ideally if not that hard, is it possible to just mark the method as deprecated and then remove next release? |
|
Created a different PR for the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the interface
exporter.Request.Merge()becauseMerge()is just a special case ofMergeSplit().With just one interface, we no longer need an if-else loop in the batcher based on MaxConfigSize.
MergeSplit()should be able to handle both the case where MaxConfigSize is specified or the case where it is notLink to tracking issue
Fixes #
Testing
All the existing cases should still pass.
Documentation