Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update versions of the new experimental modules #11897

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 15, 2024

This needs to be done again because the previously updated versions point to a commit with an invalid module version, which makes make update-otel fail on the contrib side:

go: downloading go.opentelemetry.io/collector/consumer/xconsumer v0.0.0-20241214150434-e9bc4bde924e
go: go.opentelemetry.io/collector/consumer/xconsumer@v0.115.1-0.20241213185000-4593ba7de234: unrecognized import path "go.opentelemetry.io/collector/consumer/xconsumer": empty VCS list in GOVCS: "*:"
make[3]: *** [tidy] Error 1
make[2]: *** [receiver/activedirectorydsreceiver] Error 2
make[1]: *** [gotidy] Error 2
make: *** [update-otel] Error 2

cc @songy23

This needs to be done again because the updates versions point to a commit with invalid module version which make `make update-otel` fail on contrib side:

```
go: downloading go.opentelemetry.io/collector/consumer/xconsumer v0.0.0-20241214150434-e9bc4bde924e
go: go.opentelemetry.io/collector/consumer/xconsumer@v0.115.1-0.20241213185000-4593ba7de234: unrecognized import path "go.opentelemetry.io/collector/consumer/xconsumer": empty VCS list in GOVCS: "*:"
make[3]: *** [tidy] Error 1
make[2]: *** [receiver/activedirectorydsreceiver] Error 2
make[1]: *** [gotidy] Error 2
make: *** [update-otel] Error 2
```
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (6147243) to head (30ad2a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11897   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member Author

dmitryax commented Dec 15, 2024

Not sure why exporter/datadogexporter/integrationtest is failing. Cannot reproduce it locally. I'm going to skip contrib tests

@dmitryax dmitryax added this pull request to the merge queue Dec 16, 2024
@songy23
Copy link
Member

songy23 commented Dec 16, 2024

running exporter/datadogexporter/integrationtest locally works fine for me too, agree we can skip contrib tests here

Merged via the queue into open-telemetry:main with commit cef6ce5 Dec 16, 2024
54 of 55 checks passed
@dmitryax dmitryax deleted the update-x-modules branch December 16, 2024 02:04
@github-actions github-actions bot added this to the next release milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants