Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] disable generate for now #11794

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

codeboten
Copy link
Contributor

This is a partial revert of #11670 as it is currently blocking the release due to the need to run go mod tidy multiple times.

I'm still investigating why tidy is needed multiple times, but for now I'm disabling the generate step, which was not run before and is currently blocking the release process

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This is a partial revert of open-telemetry#11670 as it is
currently blocking the release due to the need to run go mod tidy multiple times.

I'm still investigating why tidy is needed multiple times, but for now I'm disabling
the generate step, which was not run before and is currently blocking the
release process

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten added the release:blocker The issue must be resolved before cutting the next release label Dec 3, 2024
@codeboten codeboten requested a review from a team as a code owner December 3, 2024 20:25
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 3, 2024
@codeboten codeboten merged commit 311ab57 into open-telemetry:main Dec 3, 2024
67 of 68 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 3, 2024
@codeboten codeboten deleted the codeboten/partial-revert branch December 3, 2024 20:54
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (b9ff1bc) to head (37d91ff).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11794   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         447      447           
  Lines       23745    23745           
=======================================
  Hits        21712    21712           
  Misses       1657     1657           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants