Deprecate scraperhelper.Scraper in favor of scraper.Metrics #11682
+123
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Nov 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
bogdandrutu
force-pushed
the
scraper-metrics
branch
4 times, most recently
from
eedeb58 to
61522da
Compare
bogdandrutu
force-pushed
the
scraper-metrics
branch
2 times, most recently
from
6301c2e to
99e95b0
Compare
bogdandrutu
force-pushed
the
scraper-metrics
branch
4 times, most recently
from
4b10c41 to
6fee18b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11682 +/- ##
==========================================
- Coverage 91.66% 91.63% -0.04%
==========================================
Files 442 442
Lines 23766 23776 +10
==========================================
+ Hits 21785 21787 +2
- Misses 1610 1618 +8
Partials 371 371 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
scraper-metrics
branch
from
6fee18b to
6e57403
Compare
bogdandrutu
changed the title
songy23
approved these changes
Nov 19, 2024
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…emetry#11682) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.