Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Avoid public APIs with internal params #11040

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
bogdandrutu Bogdan Drutu
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu changed the title Avoid public APIs with internal params [mdatagen] Avoid public APIs with internal params Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.24%. Comparing base (15542e6) to head (d48ef96).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
...plereceiver/internal/metadata/generated_metrics.go 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11040      +/-   ##
==========================================
+ Coverage   92.22%   92.24%   +0.01%     
==========================================
  Files         409      409              
  Lines       19134    19154      +20     
==========================================
+ Hits        17646    17668      +22     
+ Misses       1127     1126       -1     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 8a07009 into open-telemetry:main Sep 13, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 13, 2024
@bogdandrutu bogdandrutu deleted the avoid-internal branch September 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants