-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension] Move optional interfaces to extensioncapabilities #11000
[extension] Move optional interfaces to extensioncapabilities #11000
Conversation
1228e61
to
7de4df4
Compare
7de4df4
to
09a712d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11000 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 406 406
Lines 19101 19101
=======================================
Hits 17618 17618
Misses 1123 1123
Partials 360 360 ☔ View full report in Codecov by Sentry. |
66f2224
to
b3a0fde
Compare
b3a0fde
to
78bf2b3
Compare
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
…ilities
@@ -0,0 +1,43 @@ | |||
module go.opentelemetry.io/collector/extension/extensioncapabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love a shorter name if we can think of one. I can't, but maybe someone else can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than just "capabilities" I am out of ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be shortened to "extensioncaps" a la the Linux capabilities family of commands, e.g. https://man7.org/linux/man-pages/man8/getpcaps.8.html. Seems OK as it is though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I feel like this is okay, we can rename later if we want to since this is not going 1.0 now. It's definitely on the longer side for a package name but it's not the longest if you take contrib component names into account
…ilities
…ilities
Description
Moves extension optional interfaces to a new module,
extensioncapabilities
.The intent is to be able to evolve these interfaces independently from the core interfaces on core.
These are used by at most one component/project, so I think they are not mature yet for 1.0