Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension] Move optional interfaces to extensioncapabilities #11000

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 29, 2024

Description

Moves extension optional interfaces to a new module, extensioncapabilities.

The intent is to be able to evolve these interfaces independently from the core interfaces on core.

These are used by at most one component/project, so I think they are not mature yet for 1.0

@mx-psi mx-psi force-pushed the mx-psi/extensioncapabilities branch 2 times, most recently from 1228e61 to 7de4df4 Compare August 29, 2024 09:24
@mx-psi mx-psi force-pushed the mx-psi/extensioncapabilities branch from 7de4df4 to 09a712d Compare August 29, 2024 10:22
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.23%. Comparing base (a26068b) to head (70595c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/extensions/extensions.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11000   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         406      406           
  Lines       19101    19101           
=======================================
  Hits        17618    17618           
  Misses       1123     1123           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi force-pushed the mx-psi/extensioncapabilities branch 2 times, most recently from 66f2224 to b3a0fde Compare August 29, 2024 10:46
@mx-psi mx-psi force-pushed the mx-psi/extensioncapabilities branch from b3a0fde to 78bf2b3 Compare August 29, 2024 11:00
@mx-psi mx-psi marked this pull request as ready for review August 29, 2024 11:07
@mx-psi mx-psi requested review from a team and TylerHelmuth August 29, 2024 11:07
mx-psi and others added 2 commits August 29, 2024 16:42
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@mx-psi mx-psi requested a review from evan-bradley August 30, 2024 10:04
@@ -0,0 +1,43 @@
module go.opentelemetry.io/collector/extension/extensioncapabilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love a shorter name if we can think of one. I can't, but maybe someone else can

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than just "capabilities" I am out of ideas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be shortened to "extensioncaps" a la the Linux capabilities family of commands, e.g. https://man7.org/linux/man-pages/man8/getpcaps.8.html. Seems OK as it is though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel like this is okay, we can rename later if we want to since this is not going 1.0 now. It's definitely on the longer side for a package name but it's not the longest if you take contrib component names into account

mx-psi added 5 commits August 30, 2024 16:49
@mx-psi mx-psi merged commit 46d0f73 into open-telemetry:main Sep 4, 2024
48 of 49 checks passed
@mx-psi mx-psi deleted the mx-psi/extensioncapabilities branch September 4, 2024 10:37
@github-actions github-actions bot added this to the next release milestone Sep 4, 2024
mx-psi added a commit that referenced this pull request Sep 10, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Follows #11000. Removes deprecated symbols.

#### Link to tracking issue

Updates #11005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants