[receiver/jaeger] Remove dependency on jaeger/cmd/agent #38655
Merged
+1,116
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
requested review from
a team,
evan-bradley,
atoulme and
tigrannajaryan
as code owners
yurishkuro
changed the title
3 tasks
mahadzaryab1
approved these changes
Mar 16, 2025
yurishkuro
added
the
ready to merge
atoulme
approved these changes
Mar 17, 2025
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jaegerreceiverwas passing null metrics factory anyway. The regular receiver metrics will be available, but not Jaeger-specific metrics about UDP packets (can be re-added later using OTEL SDK, but the whole UDP path is deprecated).jaegerreceiver.Link to tracking issue
Part of jaegertracing/jaeger#6704
Testing
All code includes extensive unit tests