[cmd/opampsupervisor] Support http endpoint #38654
Merged
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minuk-dev
requested review from
evan-bradley,
atoulme,
tigrannajaryan and
a team
as code owners
minuk-dev
changed the title
minuk-dev
force-pushed
the
opamp-http-client
branch
from
0c31f78 to
b65c5bb
Compare
|
@evan-bradley Sorry for my late applying. Could you review it, please? |
MovieStoreGuy
approved these changes
Mar 17, 2025
atoulme
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref. https://opentelemetry.io/docs/specs/opamp/#communication-model
Already opampsupervisor code considers http in the configuration, but there is no code to use http client until now.:
opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/config/config.go
Line 139 in 8dd2b7b