-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opampsupervisor] Enable emitting logs via the OTel sdk #38477
[opampsupervisor] Enable emitting logs via the OTel sdk #38477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be feasible to add a simple E2E test to verify we get these logs in an OTLP sink?
On second thought, it would make more sense as a unit test since we're not starting a Collector binary, but it would be nice to have a smoke test to determine that setting this option has the intended effect. |
@evan-bradley what did you have in mind besides the adding to the |
I think we should be able to use something in the testbed package like MockBackend to receive OTLP and check that we're getting in data. We actually do have a pretty extensive E2E test suite in |
We'll need that for traces and metrics too. Do you want me to do that in this PR or in a followup? |
Agreed, I forgot to bring it up in the other PRs. Let's just do logs in this PR and tackle traces and metrics in a follow-up. |
@evan-bradley test added |
Description
Experiment with enabling the logs SDK for the opampsupervisor telemetry
Link to tracking issue
Fixes
Testing
Updated unit test and tested manually. Here are the logs being exported to Honeycomb
Documentation