-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricstarttimeprocessor] Identify resource by hash of all attributes #38286
Labels
Comments
Pinging code owners for processor/metricstarttime: @dashpole @ridwanmsharif. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
ridwanmsharif
added a commit
to ridwanmsharif/opentelemetry-collector-contrib
that referenced
this issue
Mar 4, 2025
…meCache Fixes open-telemetry#38286. This change decouples the processor from the prometheus receiver concepts. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
added a commit
to ridwanmsharif/opentelemetry-collector-contrib
that referenced
this issue
Mar 4, 2025
…meCache Fixes open-telemetry#38286. This change decouples the processor from the prometheus receiver concepts. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
added a commit
to ridwanmsharif/opentelemetry-collector-contrib
that referenced
this issue
Mar 4, 2025
…meCache Fixes open-telemetry#38286. This change decouples the processor from the prometheus receiver concepts. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
added a commit
to ridwanmsharif/opentelemetry-collector-contrib
that referenced
this issue
Mar 4, 2025
…meCache Fixes open-telemetry#38286. This change decouples the processor from the prometheus receiver concepts. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
metricstarttime processor
Describe the issue you're reporting
Currently, the implementation of true reset points in the prometheusreceiver only uses
service.name
andservice.instance.id
to identify a resource:opentelemetry-collector-contrib/receiver/prometheusreceiver/internal/metrics_adjuster.go
Line 268 in 6ea0ea7
This logic is being copied to the metricstarttime processor in #37855. However, this logic is prometheus-specific, and should use a hash of all resource attributes instead of just those two.
Possible solutions
This identity library may be helpful here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/6ea0ea7e0423dd5271cc4ef1b6bde21d6f598412/internal/exp/metrics/identity.
Alternatively, we could use
hash/fnv
, similar to https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/19c4db6ea12211308fbd2cba12cc8665a5b7c890/exporter/collector/internal/datapointstorage/datapointcache.go#L250. This is similar to how the prometheus server constructs hashes of labels.The text was updated successfully, but these errors were encountered: