-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap/provider/secretsmanagerprovider] Add support for default values #37535
[confmap/provider/secretsmanagerprovider] Add support for default values #37535
Conversation
aad8ada
to
2ec0176
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
2ec0176
to
f4ee8f7
Compare
Still relevant, rebased onto latest main now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and linter are failing, please fix
a6f590f
to
fa92974
Compare
fa92974
to
08dc473
Compare
Rebased the PR and fixed the previous linter issues |
Description
This PR adds support for default values when using the
secretsmanager
provider.It uses the same syntax as the
envprovider
and falls back to the default value when:In both cases, a warning is logged to call out unintentional fallback.
By nesting substitutions, this allows users to specify either a secret manager reference or plain value through environment variables like this:
When
PASSWORD_ARN
is set, the collector retrieves the value from AWS Secrets Manager, falling back to the value specified inPASSWORD
if the secret is not found or the json key inPASSWORD_ARN
is undefined.Testing
Documentation