Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Change default mapping mode to otel #37241

Closed
carsonip opened this issue Jan 15, 2025 · 9 comments · Fixed by #38458
Closed

[exporter/elasticsearch] Change default mapping mode to otel #37241

carsonip opened this issue Jan 15, 2025 · 9 comments · Fixed by #38458
Labels

Comments

@carsonip
Copy link
Contributor

carsonip commented Jan 15, 2025

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

None and raw mapping mode are not useful in kibana UI

Describe the solution you'd like

change mapping mode default to otel to deliver better user experience out of the box, without deprecating existing mapping modes

Describe alternatives you've considered

No response

Additional context

No response

@carsonip carsonip added enhancement New feature or request needs triage New item requiring triage labels Jan 15, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@carsonip
Copy link
Contributor Author

/label -needs-triage

@github-actions github-actions bot removed the needs triage New item requiring triage label Jan 15, 2025
@felixbarny
Copy link
Contributor

This may be a bit of a controversial issue. I'd specifically like to get input from @JaredTan95 of your usage of the none and raw mapping modes. Would it be feasible for the use cases you know about to switch to the otel mapping mode?

@carsonip
Copy link
Contributor Author

carsonip commented Feb 5, 2025

pinging @JaredTan95 again in case the previous notification was missed

@JaredTan95
Copy link
Member

raw mode was introduced by #29619, I think you can switch the default mode to otel( better user experience in kibana case), but other modes should not be deprecated.

@felixbarny
Copy link
Contributor

@ycombinator do you think the raw mode is still needed or is it superseded by bodymap and ecs?

@carsonip carsonip changed the title [exporter/elasticsearch] Deprecate none and raw mapping mode [exporter/elasticsearch] Change default mapping mode to otel Feb 26, 2025
@carsonip
Copy link
Contributor Author

carsonip commented Feb 26, 2025

I've updated this issue to not require a deprecation of any mapping modes (let's do it at any other time), but to just change the default mapping mode to otel. I wonder if #37283 is a blocker.

@felixbarny
Copy link
Contributor

The simplest would be to just document ES 8.12 to be a requirement for the default config. In order to get proper mappings in otel mode, you need to use ES 8.16+ anyway. Unless we're removing mapping modes, users can still choose another mapping mode that doesn't use require_data_stream. We need to mark this change as a breaking change either way. Users that wish to keep the none mapping mode will need to set this explicitly.

If it turns out to be important to support older versions of ES with the otel mapping mode, we could also just add a config option to disable require_data_stream. At least, that will make it possible to use with older ES versions. At that point, we'll probably also want to document the mappings you should apply. But at this point, I'm not convinced that this is urgent.

Bottom line is that I don't think it's a blocker.

@carsonip
Copy link
Contributor Author

sgtm, let's proceed with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants