Move the xray allowdot feature gate to beta stage #32694
Merged
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Apr 25, 2024
Thanks for your comment, added changelog. Let me know if any else concern |
songy23
approved these changes
Apr 27, 2024
crobert-1
reviewed
Apr 29, 2024
| component: awsxrayexporter | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: change x-ray exporter's translator to make "." split annotation pass as-is |
There was a problem hiding this comment.
This should mention the feature gate name, and the fact that it's being upgraded from Alpha to Beta, along with the description you already have here.
mxiamxia
approved these changes
Apr 29, 2024
crobert-1
approved these changes
Apr 30, 2024
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moving xray exporter allow-dot feature gate from alpha to beta stage
It's a follow up change for #31732
Testing: Unit test
Documentation:
https://github.com/XinRanZhAWS/opentelemetry-collector-contrib/blob/f0863f481445e7205e3096a9a536463e3a51de81/.chloggen/xray_exporter_allow_dot_annotation.yaml
Purpose of this feature gate:
In the past, X-Ray doesn’t support “.”. So we have a translator in x-ray export to translates it to “_” before sending traces to X-Ray Service.
To match otel naming style, x-ray service team decide to change their service to support both "." type and "" type of naming. In this case the translator that translate "." to "" is no-longer needed. This PR change the way this translator work
X-Ray PMs agree on rolling out this change by using feature-gate