-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update virtual node defaults and change feature gate to beta #31734
Labels
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Mar 19, 2024
Hello @Frapschen, the PR has been reviewed, but it is waiting for approval from another maintainer which seems like he isn't receiving notifications or is busy (he is active on other issues). Would it be possible to get a approval/final review (if necessary) on this PR? Thanks a lot 😄 |
dmitryax
pushed a commit
that referenced
this issue
Apr 14, 2024
Loading
Loading status checks…
…ure gate to beta (#31735) **Description:** - Change default values to peer.service, db.name and db.system (in this order). These are compliant with conventions, and the same as the tempo service graph uses. - Switch the feature from "alpha" to "beta". Virtual nodes are working well on the tempo side, and feature could be disabled anyway by using an empty list if needed. - Reword documentation for improved clarity - Fix "processor" that should be "connector" instead since recent commit **Link to tracking Issue:** #31734 **Testing:** No functional change requiring additional tests **Documentation:** Updated documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
connector/servicegraph
Context
Started with this discussion: grafana/tempo#3480 (reply in thread)
@joe-elliott
The servicegraph connector has a feature for creating virtual nodes. There are currently three issues:
net.peer.name
(replaced byserver.address
on client spans andclient.address
on server spans)net.sock.peer.name
(removed)net.sock.peer.addr
(replaced bynetwork.peer.address
)http.url
(replaced byurl.full
)http.target
(split tourl.path
andurl.query
)Proposition
peer.service
,db.name
anddb.system
(in this order). These are compliant with conventions, and the same as the tempo service graph uses.See PR: #31735
The text was updated successfully, but these errors were encountered: