Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] operators - make logging more verbose #27088

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

VihasMakwana
Copy link
Contributor

Description: If we have multiple move/remove operators in the pipeline, and if some of them fail, the error message isn't that much of a help because all it prints is:
move: field does not exist.
Whereas, the copy operator's error message looks like this:
copy: from field does not exist: FIELD_NAME

Make logging sensible by including which field is missing while removing/moving

@VihasMakwana VihasMakwana requested a review from a team September 24, 2023 16:25
@VihasMakwana VihasMakwana changed the title fix: make logging more verbose [pkg/stanza] operators - make logging more verbose Sep 24, 2023
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 25, 2023
@djaglowski djaglowski merged commit a319a5b into open-telemetry:main Sep 25, 2023
@github-actions github-actions bot added this to the next release milestone Sep 25, 2023
@VihasMakwana VihasMakwana deleted the fix-logging-operators branch September 26, 2023 06:58
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
)

**Description:** If we have multiple move/remove operators in the
pipeline, and if some of them fail, the error message isn't that much of
a help because all it prints is:
`move: field does not exist`. 
Whereas, the `copy` operator's error message looks like this:
`copy: from field does not exist: FIELD_NAME`

Make logging sensible by including which field is missing while
removing/moving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants