Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps command has poor memory footprint #6685

Closed
johanfylling opened this issue Apr 9, 2024 · 0 comments · Fixed by #6688
Closed

deps command has poor memory footprint #6685

johanfylling opened this issue Apr 9, 2024 · 0 comments · Fixed by #6688
Labels
bug
Projects
Open Policy Agent

Comments

@johanfylling
Copy link
Contributor

The deps command recursively visits each dependency of a given ref; collecting the ref for each hit. Duplicate refs are pruned after the fact, and rules already visited will be revisited as they are encountered. This results in a very poor memory footprint and execution time for highly "connected" Rego projects.
@johanfylling johanfylling added this to Backlog in Open Policy Agent via automation Apr 9, 2024
@johanfylling johanfylling moved this from Backlog to Planning - v0.64 in Open Policy Agent Apr 9, 2024
@johanfylling johanfylling moved this from Planning - v0.64 to In Progress in Open Policy Agent Apr 9, 2024
johanfylling added a commit to johanfylling/opa that referenced this issue Apr 9, 2024
@johanfylling
deps: Improving deps command memory footprint
621aaba 
Fixes: open-policy-agent#6685
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
@johanfylling johanfylling mentioned this issue Apr 9, 2024
Merged
Open Policy Agent automation moved this from In Progress to Done Apr 9, 2024
tsidebottom pushed a commit to tsidebottom/opa- that referenced this issue Apr 17, 2024
@johanfylling @tsidebottom
deps: Improving deps command performance (open-policy-agent#6688)
248337c 
Improving memory footprint and execution time of deps command for policies with high dependency connectivity.

Fixes: open-policy-agent#6685
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
@BrewTestBot BrewTestBot mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Open Policy Agent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Improving deps command performance johanfylling/opa
1 participant
@johanfylling