cmd & format: Adding rego-v1 mode to opa fmt
#6413
Conversation
Fixes: open-policy-agent#6297 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
* duplicate imports * data/input root document overrides * deprecated built-in usage Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Conflicts: ast/compile.go
| @@ -0,0 +1,112 @@ | |||
| package ast | |||
There was a problem hiding this comment.
We're now exposing internal compiler logic here. Should be put this in an internal package instead?
There was a problem hiding this comment.
I tried that, but since we also need to call this from the compiler which lives in the ast package which is heavily used from these functions, we get a circular import that fails compilation.
If there aren't clever ways around that, I suppose the alternative is to duplicate the functionality, so it can be used both in the compiler and in the formatter without making it public.
Perhaps the lesser evil is to eat the redundancy and not make this public .. I don't know 🤔. What do you think?
There was a problem hiding this comment.
I would say let's try to minimize the replication as much as we can. Exposing these methods does not seem like a good idea. Moving them to an internal package will require a lot of refactoring.
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Conflicts: ast/compile.go
Adding
--rego-v1flag toopa fmtcommand.Calls to deprecated built-ins are not rewritten to equivalent v1-compliant code; we can add this separately.
Fixes: #6297