chore: Replace ghodss/yaml with sigs.k8s.io/yaml #6195
Merged
+260
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fork that is maintained by the kubernetes community. https://github.com/kubernetes-sigs/yaml Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
Hi there! And thanks. #5754 provides some context for why this hasn’t been considered too important in the past. Do you know if the issue described there is solved now? I’m on mobile so I can’t easily see until later :) |
|
@anderseknert 👋 thanks for the context, I wasn't aware that there's an issue already! I'll take a look tomorrow and see if this change is able to fix the issue as well. |
|
Just to be clear, I didn’t mean we shouldn’t merge this if not. But whatever we use would be temporary until we have a something addressing those issues. |
|
The issue #5754 is not fixed by this change but likely will be if kubernetes-sigs/yaml#76 is merged into the upstream repository. |
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
ghodss/yaml hasn't seen any commits since 2019 (the last one was a change in README), sigs.k8s.io/yaml is a more recent and more active fork supported by the kubernetes community.
https://github.com/kubernetes-sigs/yaml
What are the changes in this PR?
Migrate dependency from ghodss/yaml to sigs.k8s.io/yaml
Notes to assist PR review:
Further comments:
Here's a similar change that got included in gatekeeper already:
open-policy-agent/gatekeeper#2697