Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Implement gherkin hooks tests #442

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Feb 10, 2025

Fix and implement the gherkin tests for hooks and metadata.

Waiting for open-feature/spec#294

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow chrfwow marked this pull request as draft February 10, 2025 11:47
@chrfwow chrfwow changed the title Implement gherkin hooks tests test: Implement gherkin hooks tests Feb 10, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (ba0213e) to head (1d87260).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          32       32           
  Lines        1621     1621           
=======================================
  Hits         1584     1584           
  Misses         37       37           
Flag Coverage Δ
unittests 97.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrfwow and others added 4 commits February 10, 2025 16:38
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ement-hooks-tests
Signed-off-by: gruebel <anton.gruebel@gmail.com>
lint
Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel marked this pull request as ready for review February 11, 2025 21:12
@gruebel gruebel merged commit d4f53b4 into open-feature:main Feb 11, 2025
15 checks passed
@chrfwow chrfwow deleted the implement-hooks-tests branch February 12, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants