fix(flagd): fix semver version parsing to allow "v" prefix(#106) #107
+74
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
approved these changes
Nov 21, 2024
aepfli
force-pushed
the
feat/106-fix_semver_versions
branch
from
637442a to
43628f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 90.55% 95.21% +4.66%
==========================================
Files 8 13 +5
Lines 180 481 +301
==========================================
+ Hits 163 458 +295
- Misses 17 23 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
aepfli
force-pushed
the
feat/106-fix_semver_versions
branch
from
43628f5 to
f1b9b6c
Compare
…re#106) Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/106-fix_semver_versions
branch
from
f1b9b6c to
b55a198
Compare
gruebel
reviewed
Nov 21, 2024
...eature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/custom_ops.py
Outdated
Show resolved
Hide resolved
…rovider/flagd/resolvers/process/custom_ops.py Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
chrfwow
approved these changes
Nov 22, 2024
|
@aepfli can you sync your branch, i can't do it somehow, probably no permission to do so on your fork. |
updated ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #106