fix(nest): add peer deps for nestjs-core and rxjs 9 #784
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
fix/add-nestjs-core-peer-dep
branch
from
07eaf87 to
3636b67
Compare
luizgribeiro
approved these changes
Jan 24, 2024
beeme1mr
approved these changes
Jan 25, 2024
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
approved these changes
Jan 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.5-experimental](nestjs-sdk-v0.0.4-experimental...nestjs-sdk-v0.0.5-experimental) (2024-01-31) ### ✨ New Features * adds ErrorOptions to Error constructor ([#765](#765)) ([2f59a9f](2f59a9f)) ### 🐛 Bug Fixes * **nest:** add peer deps for nestjs-core and rxjs 9 ([#784](#784)) ([a452bdd](a452bdd)) * removed duped core types ([#800](#800)) ([7cc1e09](7cc1e09)) ### 📚 Documentation * Nest SDK ([#750](#750)) ([a21634d](a21634d)) * update nestjs readme examples ([#787](#787)) ([c6a357a](c6a357a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds
@nestjs/coreand rxjs version 8 to peer deps of nestjs-sdk.Also fixes typos in README.