test: Update gherkin test sub module #1236
Conversation
…sts definitions Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>
warber
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
============================================
+ Coverage 93.07% 93.26% +0.19%
- Complexity 441 442 +1
============================================
Files 41 41
Lines 1025 1025
Branches 85 85
============================================
+ Hits 954 956 +2
+ Misses 44 43 -1
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
warber
force-pushed
the
feat/update-gherkin-test-sub-module
branch
2 times, most recently
from
f7dfb84 to
50b34c8
Compare
src/test/java/dev/openfeature/sdk/e2e/evaluation/StepDefinitions.java
Outdated
Show resolved
Hide resolved
warber
changed the title
Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>
warber
force-pushed
the
feat/update-gherkin-test-sub-module
branch
from
50b34c8 to
7f08771
Compare
| [submodule "test-harness"] | ||
| path = test-harness | ||
| url = https://github.com/open-feature/test-harness | ||
| [submodule "spec"] |
There was a problem hiding this comment.
i think it's not required to call this spec. Alternatively we could keep calling i "test-harness" (same for path).
no hard feeling there tho. wdyt?
There was a problem hiding this comment.
i would go with spec, to be more precise, as we are using spec and test-harness in the contrib repos
|
|
Ah thanks. This has been wrong for a long time. |
This PR
the git submodule pointed to a wrong/old repository.
This PR fixes it by changing the git module to point to the OF spec repository where the gherkin test definitions reside.
Additionally, I've moved the java test definitions into their own package with the motivation to have it nicely separated, e.g. when introducing the next test suite.