chore: require go 1.21 #294
Merged
+10
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
requested review from
bacherfl,
kinyoklion,
Kavindu-Dodan,
aepfli,
craigpastro and
lukas-reining
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 10 10
Lines 1215 1215
=======================================
Hits 995 995
Misses 199 199
Partials 21 21 ☔ View full report in Codecov by Sentry. |
toddbaert
requested review from
beeme1mr,
pradeepbbl and
liran2000
and removed request for
bacherfl
liran2000
approved these changes
Oct 22, 2024
beeme1mr
reviewed
Oct 22, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
lukas-reining
approved these changes
Oct 22, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
approved these changes
Oct 22, 2024
|
Did you forget to update README.md? 
Also, Go 1.21 is no longer supported. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require go 1.21.
1.20 has long been EOL: https://endoflife.date/go
This is consistent with our guidelines on runtime support.