Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Unlease Go Client v4 #620

Conversation

cescribanohs
Copy link
Contributor

@cescribanohs cescribanohs commented Feb 3, 2025

This PR

This is an update for unleash-client-go/v4

@cescribanohs cescribanohs requested a review from a team as a code owner February 3, 2025 18:13
cupofcat and others added 2 commits February 3, 2025 22:20
…-feature#616)

Signed-off-by: Maks Osowski <maks@google.com>
Signed-off-by: Carles Escribano <carles.escribano@helpsystems.com>
Signed-off-by: Carles Escribano <carles.escribano@helpsystems.com>
@cescribanohs cescribanohs force-pushed the chore/update_unleash_client_go_v_3_9_2 branch from 42f68ba to cce440f Compare February 3, 2025 22:21
Signed-off-by: Carles Escribano <carles.escribano@helpsystems.com>
@cescribanohs cescribanohs force-pushed the chore/update_unleash_client_go_v_3_9_2 branch from cce440f to 4a97b82 Compare February 4, 2025 09:13
Signed-off-by: Carles Escribano <carles.escribano@helpsystems.com>
Signed-off-by: Carles Escribano <carles.escribano@helpsystems.com>
@cescribanohs cescribanohs changed the title chore: update unleash client go v.3.9.2 chore: update unleash-client-go/v4 Feb 5, 2025
@beeme1mr
Copy link
Member

beeme1mr commented Feb 5, 2025

Hey @cescribanohs, thanks for the PR. It looks like the PR description is out of date.

@cescribanohs
Copy link
Contributor Author

Hey @cescribanohs, thanks for the PR. It looks like the PR description is out of date.

Thank you @beeme1mr I have updated it

@cescribanohs cescribanohs changed the title chore: update unleash-client-go/v4 fix(deps): update module github.com/unleash/unleash-client-go/v3.9.2 to v4.1.4 Feb 5, 2025
@beeme1mr beeme1mr changed the title fix(deps): update module github.com/unleash/unleash-client-go/v3.9.2 to v4.1.4 feat!: upgrade to Unlease Go Client v4 Feb 5, 2025
@beeme1mr
Copy link
Member

beeme1mr commented Feb 5, 2025

I've updated the title and marked it as breaking since it will require a major version bump of the Unleash SDK. I'll wait for @liran2000's opinion before merging.

Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like version change only, and all checks have passed.

@beeme1mr beeme1mr merged commit 5f1e4f2 into open-feature:main Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants