Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support supplying a custom sync provider for in-process flagd #598

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

cupofcat
Copy link
Contributor

@cupofcat cupofcat commented Dec 2, 2024

This PR

  • When the user is using in-process flagd, allows them to supply a sync.ISync implementation of their own that can fetch the flag config in any way they like.

Notes

This PR provides the capability in Go that was recently added in Java.

Signed-off-by: Maks Osowski <maks@google.com>
Signed-off-by: Maks Osowski <maks@google.com>
@beeme1mr
Copy link
Member

beeme1mr commented Dec 2, 2024

Hey @cupofcat, thanks for the PR. Could you please add a short section to the README that explains how to configure a custom sync provider? It can be similar to what was done in Java.

@beeme1mr beeme1mr requested a review from warber December 2, 2024 16:12
…option

Signed-off-by: Maks Osowski <maks@google.com>
Signed-off-by: Maks Osowski <maks@google.com>
…ync Provider

Signed-off-by: Maks Osowski <maks@google.com>
… the interface

Signed-off-by: Maks Osowski <maks@google.com>
…sync provider

Signed-off-by: Maks Osowski <maks@google.com>
@toddbaert toddbaert changed the title feat(flagd): Support supplying a custom sync provider for in-process flagd feat: Support supplying a custom sync provider for in-process flagd Dec 19, 2024
toddbaert added a commit to open-feature/community that referenced this pull request Dec 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@cupofcat has been working on flagd and flagd providers:

- open-feature/go-sdk-contrib#598
- open-feature/flagd#1481
- open-feature/flagd#1487


Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit bfa642a into open-feature:main Dec 19, 2024
6 checks passed
@cupofcat cupofcat deleted the custom-sync-provider branch January 30, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants