Skip to content

Change functional tests library #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
askpt opened this issue Jan 31, 2025 · 0 comments · Fixed by #368 or #372
Closed

Change functional tests library #354

askpt opened this issue Jan 31, 2025 · 0 comments · Fixed by #368 or #372
Assignees
@askpt
Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite

Comments

@askpt
Copy link
Member

askpt commented Jan 31, 2025

Description

The SpecFlow library was deprecated on December 31st, 2024. We should transition to another library currently actively supported for our functional tests suite. We are currently blocked from upgrading xUnit since SpecFlow depends on xUnit version 2.
One of the possibilities is Reqnroll.

More information
@askpt askpt added dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite labels Jan 31, 2025
@askpt askpt self-assigned this Feb 5, 2025
@askpt askpt mentioned this issue Feb 5, 2025
Merged
@askpt askpt linked a pull request Feb 5, 2025 that will close this issue
chore: Replace SpecFlow with Reqnroll for testing framework #368
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 11, 2025
@askpt
chore: Replace SpecFlow with Reqnroll for testing framework (#368)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed6ee2c 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->
This pull request includes updates to the testing framework by replacing
SpecFlow with Reqnroll across multiple files.

Testing framework updates:

*
[`Directory.Packages.props`](diffhunk://#diff-5baf5f9e448ad54ab25a091adee0da05d4d228481c9200518fcb1b53a65d4156L29-R29):
Replaced SpecFlow packages with Reqnroll.xUnit package.
*
[`test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj`](diffhunk://#diff-ab2ad60395e1cc72b327459243ed8c5711efbd88531a3b3b813fb6c4c6019886L19-R19):
Updated package references to use Reqnroll.xUnit instead of SpecFlow
packages.
*
[`test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs`](diffhunk://#diff-9ca6e89533e4b3f7a2deaf8de6d6f07a80b7eab2afa6f2e8bfc682b9ca60dc6bL7-R7):
Replaced `TechTalk.SpecFlow` with `Reqnroll` in the using directives.

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes #354

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@openfeaturebot openfeaturebot mentioned this issue Feb 11, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2025
@openfeaturebot
chore(main): release 2.3.2 (#372)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f1bf7a6 
🤖 I have created a release *beep* *boop*
---


##
[2.3.2](v2.3.1...v2.3.2)
(2025-03-24)


### 🐛 Bug Fixes

* Address issue with newline characters when running Logging Hook Unit
Tests on linux
([#374](#374))
([a98334e](a98334e))
* Remove virtual GetEventChannel from FeatureProvider
([#401](#401))
([00a4e4a](00a4e4a))
* Update project name in solution file
([#380](#380))
([1f13258](1f13258))


### 🧹 Chore

* Correct LoggingHookTest timestamp handling.
([#386](#386))
([c69a6e5](c69a6e5))
* **deps:** update actions/setup-dotnet digest to 67a3573
([#402](#402))
([2e2c489](2e2c489))
* **deps:** update actions/upload-artifact action to v4.6.1
([#385](#385))
([accf571](accf571))
* **deps:** update actions/upload-artifact action to v4.6.2
([#406](#406))
([16c92b7](16c92b7))
* **deps:** update codecov/codecov-action action to v5.4.0
([#392](#392))
([06e4e3a](06e4e3a))
* **deps:** update dependency dotnet-sdk to v9.0.202
([#405](#405))
([a4beaae](a4beaae))
* **deps:** update dependency microsoft.net.test.sdk to 17.13.0
([#375](#375))
([7a735f8](7a735f8))
* **deps:** update dependency reqnroll.xunit to 2.3.0
([#378](#378))
([96ba568](96ba568))
* **deps:** update dependency reqnroll.xunit to 2.4.0
([#396](#396))
([b30350b](b30350b))
* **deps:** update dependency system.valuetuple to 4.6.0
([#403](#403))
([75468d2](75468d2))
* **deps:** update dotnet monorepo
([#379](#379))
([53ced91](53ced91))
* **deps:** update dotnet monorepo to 9.0.2
([#377](#377))
([3bdc79b](3bdc79b))
* **deps:** update github/codeql-action digest to 1b549b9
([#407](#407))
([ae9fc79](ae9fc79))
* **deps:** update github/codeql-action digest to 5f8171a
([#404](#404))
([73a5040](73a5040))
* **deps:** update github/codeql-action digest to 6bb031a
([#398](#398))
([9b6feab](9b6feab))
* **deps:** update github/codeql-action digest to 9e8d078
([#371](#371))
([e74e8e7](e74e8e7))
* **deps:** update github/codeql-action digest to b56ba49
([#384](#384))
([cc2990f](cc2990f))
* **deps:** update spec digest to 0cd553d
([#389](#389))
([85075ac](85075ac))
* **deps:** update spec digest to 54952f3
([#373](#373))
([1e8b230](1e8b230))
* **deps:** update spec digest to a69f748
([#382](#382))
([4977542](4977542))
* remove FluentAssertions
([#361](#361))
([4ecfd24](4ecfd24))
* Replace SpecFlow with Reqnroll for testing framework
([#368](#368))
([ed6ee2c](ed6ee2c)),
closes [#354](#354)
* update release please repo, specify action permissions
([#369](#369))
([63846ad](63846ad))


### 🔄 Refactoring

* Improve EventExecutor
([#393](#393))
([46274a2](46274a2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askpt askpt

Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite
Projects
None yet
Milestone
No milestone
1 participant
@askpt