Prevent nil-dereference in format.Object for boxed nil error #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
commented
Jul 14, 2023
| @@ -259,7 +259,7 @@ func Object(object interface{}, indentation uint) string { | |||
| indent := strings.Repeat(Indent, int(indentation)) | |||
| value := reflect.ValueOf(object) | |||
| commonRepresentation := "" | |||
| if err, ok := object.(error); ok { | |||
| if err, ok := object.(error); ok && !isNilValue(value) { // isNilValue check needed here to avoid nil deref due to boxed nil | |||
There was a problem hiding this comment.
Happy to remove this comment if you feel it's unneeded.
|
this looks good to me! thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #680