Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge coverages instead of combining them (#1329) #1340

Merged
merged 2 commits into from Jan 24, 2024

Conversation

myzhan
Copy link
Contributor

@myzhan myzhan commented Jan 20, 2024

I copy gocovmerge to ginkgo, because it hasn't versions, and the code is easy to maintain.

@onsi
Copy link
Owner

onsi commented Jan 23, 2024

Sorry for the delay - thanks this looks good to me. I only have one request, can you include the original license:
https://github.com/wadey/gocovmerge/blob/master/LICENSE

by adding it to the comment at the top of the new gocovmerge.go file? It’s a BSD-2 simplified license so I believe the two are largely compatible but I think it’s best to list it explicitly and make sure Wade Simmons gets the copyright notice.

@wadey please let us know if you have any concerns!

@onsi
Copy link
Owner

onsi commented Jan 24, 2024

perfect, thanks!

@onsi onsi merged commit 23f0cc5 into onsi:master Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants