Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GinkgoTB() function #1333

Merged
merged 1 commit into from Jan 9, 2024
Merged

Add GinkgoTB() function #1333

merged 1 commit into from Jan 9, 2024

Conversation

ebabani
Copy link
Contributor

@ebabani ebabani commented Jan 8, 2024

This function returns a wrapper around GinkgoT() which satisfies the testing.TB interface.

  • Update fail tests with tests for GinkgoT() and GinkgoTB().
  • Fix a bug where GinkgoT().Fail() was not reporting the correct line on error.

@onsi
Copy link
Owner

onsi commented Jan 8, 2024

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

This function returns a wrapper around GinkgoT() which satisfies the `testing.TB` interface.

- Update fail tests with tests for GinkgoT() and GinkgoTB().
- Fix a bug where GinkgoT().Fail() was not reporting the correct line on error.
@ebabani
Copy link
Contributor Author

ebabani commented Jan 8, 2024

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

I pushed a fix for that failure. Forgot to run those tests and was only running integration tests.

I updated the symbol check to ignore functions with a receiver. Those methods are never going to cause an import conflict, and I added the missing package level functions and types to core_dsl.go.

@onsi onsi merged commit 92b6744 into onsi:master Jan 9, 2024
6 checks passed
@onsi
Copy link
Owner

onsi commented Jan 9, 2024

fantastic, thank you! i’ll cut a release soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants