Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow MustPassRepeatedly decorator to be set at suite level #1266

Merged

Conversation

maxcleme
Copy link
Contributor

Relates to #1265

Aims to allow MustPassRepeatedly to be set at suite level programatically, similarly of FlakeAttempts.

Signed-off-by: maxcleme <maxime.clement@docker.com>
@maxcleme
Copy link
Contributor Author

maxcleme commented Aug 23, 2023

Regarding the test, I'm not sure which way I should go

  • either add a new cases in integration/_fixtures/decorations_fixture/flaky_repeated/flaky_repeated_fixture_suite_test.go, using suite config instead of node decorator
  • edit integration/_fixtures/config_override_fixture/config_override_fixture_suite_test.go (which seems relevant?)
  • same as internal/internal_integration/config_flake_attempts_test.go ?

@onsi any thoughts? 😁

@onsi
Copy link
Owner

onsi commented Aug 23, 2023

i’ll try to take a closer look today but to unblock you:

  • i’d definitely like an internal integration test - and it would be good to ensure that the override at the suite level plays nicely with any per-test values (happy to think through what the behavior should be with you. at first blush i’d say it should do whatever FlakeAttempts does.)
  • the outside-in integration test is less crucial. one of the two you point out should be enough

@maxcleme maxcleme force-pushed the feat/allow_suite_level_must_pass_repeatedly branch from 81b93f0 to 81926db Compare August 23, 2023 14:36
Signed-off-by: maxcleme <maxime.clement@docker.com>
@maxcleme maxcleme force-pushed the feat/allow_suite_level_must_pass_repeatedly branch from 81926db to 5dbcd2a Compare August 23, 2023 14:38
integration/repeat_test.go Outdated Show resolved Hide resolved
@maxcleme maxcleme marked this pull request as ready for review August 23, 2023 14:44
Signed-off-by: maxcleme <maxime.clement@docker.com>
@maxcleme maxcleme marked this pull request as draft August 23, 2023 14:47
…rride

Signed-off-by: maxcleme <maxime.clement@docker.com>
@maxcleme maxcleme force-pushed the feat/allow_suite_level_must_pass_repeatedly branch from 5dbcd2a to 880399d Compare August 23, 2023 14:51
@maxcleme maxcleme marked this pull request as ready for review August 23, 2023 14:52
@maxcleme
Copy link
Contributor Author

@onsi I've added some tests, let me know what you think!

@onsi onsi merged commit 05de518 into onsi:master Aug 23, 2023
6 checks passed
@onsi
Copy link
Owner

onsi commented Aug 23, 2023

i just cut a release with this in it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants