Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about Measure() deprecation. #1176

Closed
geofffranks opened this issue Mar 30, 2023 · 2 comments
Closed

Confusion about Measure() deprecation. #1176

geofffranks opened this issue Mar 30, 2023 · 2 comments

Comments

@geofffranks
Copy link

We have tests that are emitting Measure is deprecated and will be removed in Ginkgo V2. Please migrate to gomega/gmeasure after upgrading to V2.

However, according to the v2 docs, the functionality was removed and tests aren't even run.

Since v2 was a breaking change from v1, shouldn't Measure() instead just cause failures, similar to how other calls to deprecated functionality do? If not, can the message at least be changed from will be removed in Ginkgo V2 to has been removed as of Ginkgo V2 and these tests are not being run or something similar?

@onsi
Copy link
Owner

onsi commented Mar 30, 2023

hey - thanks. it should say has been removed as of Ginkgo V2 and these tests are not being run. I'll fix that.

I'd like to keep the "deprecation" behavior in place however, as opposed to failing the test, as it provides a gentler onramp for folks migrating from V1.

@onsi onsi closed this as completed in 227c662 Mar 30, 2023
@onsi
Copy link
Owner

onsi commented Mar 30, 2023

i've updated this now. it'll get released when the next version of Ginkgo gets cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants