Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-task/slim-sprig #1167

Merged
merged 1 commit into from Mar 23, 2023
Merged

Conversation

SalDaniele
Copy link
Contributor

There is a known vulnerability in version of gopkg.in/yaml.v2 prior to v2.2.4 [1]. Currently this vulnerability is indirectly referenced as follows:

Ginkgo requires github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0

github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 requires github.com/stretchr/testify v1.5.1

github.com/stretchr/testify v1.5.1 requires gopkg.in/yaml.v2 v2.2.2

This commit bumps slim-sprig to the most recent commit, in which github.com/stretchr/testify v1.6.1 is used and does not include the vulnerability

[1] https://pkg.go.dev/vuln/GO-2022-0956

There is a known vulnerability in version of gopkg.in/yaml.v2 prior to
v2.2.4 [1]. Currently this vulnerability is indirectly referenced as
follows:

Ginkgo requires github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0

github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0
requires github.com/stretchr/testify v1.5.1

github.com/stretchr/testify v1.5.1 requires gopkg.in/yaml.v2 v2.2.2

This commit bumps slim-sprig to the most recent commit, in which
github.com/stretchr/testify v1.6.1 is used and does not include the
vulnerability

[1] https://pkg.go.dev/vuln/GO-2022-0956

Signed-off-by: Salvatore Daniele <sdaniele@redhat.com>
@bn222
Copy link

bn222 commented Mar 23, 2023

Can we get this merged asap? It's blocking some of our work.

@onsi onsi merged commit 3fcc5bf into onsi:master Mar 23, 2023
6 checks passed
@blgm
Copy link
Collaborator

blgm commented Mar 23, 2023

Beat me to it @onsi...

@bn222 @SalDaniele did you need a new release cutting too?

@SalDaniele
Copy link
Contributor Author

It would help keep things cleaner if possible, no worries if not

@blgm
Copy link
Collaborator

blgm commented Mar 23, 2023

Looks like @onsi beat me to that too and just cut v2.9.2

@onsi
Copy link
Owner

onsi commented Mar 23, 2023

ha! - thanks @blgm !

I'll take this opportunity to gently mention that Ginkgo/Gomega do not have a CLA around providing security patches in a timely manner. If your organization has a business-critical dependence on Ginkgo/Gomega please consider asking your management to sponsor the project.

I'll cut a new gomega release now too.

@onsi
Copy link
Owner

onsi commented Mar 23, 2023

btw @blgm i've now scripted the release process (at least on my machine - i have a nice little shipit binary) and that has vastly reduced the cost of cutting a release for me, so i can turn that around super quickly now.

@SalDaniele SalDaniele deleted the bump_slim_sprig branch March 23, 2023 17:02
@SalDaniele
Copy link
Contributor Author

Great, thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants