Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: onsi/ginkgo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.23.2
Choose a base ref
...
head repository: onsi/ginkgo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.23.3
Choose a head ref
  • 4 commits
  • 6 files changed
  • 2 contributors

Commits on Mar 20, 2025

  1. ignore exit code for symbol test on linux

    onsi committed Mar 20, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    unstubbable Hendrik Liebau
    Copy the full SHA
    88e2282 View commit details

Commits on Mar 21, 2025

  1. Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()

    andrewradamis-vividseats authored and onsi committed Mar 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    unstubbable Hendrik Liebau
    Copy the full SHA
    feaf292 View commit details
  2. allow - as a standalone argument

    onsi committed Mar 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    unstubbable Hendrik Liebau
    Copy the full SHA
    cfcc1a5 View commit details
  3. v2.23.3

    onsi committed Mar 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    unstubbable Hendrik Liebau
    Copy the full SHA
    04a9a74 View commit details
Showing with 19 additions and 6 deletions.
  1. +8 −0 CHANGELOG.md
  2. +1 −1 ginkgo/command/command.go
  3. +2 −2 ginkgo/command/command_test.go
  4. +6 −0 ginkgo_t_dsl.go
  5. +1 −2 integration/_fixtures/symbol_fixture/symbol_fixture_suite_test.go
  6. +1 −1 types/version.go
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 2.23.3

### Fixes

- allow `-` as a standalone argument [cfcc1a5]
- Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
- ignore exit code for symbol test on linux [88e2282]

## 2.23.2

🎉🎉🎉
2 changes: 1 addition & 1 deletion ginkgo/command/command.go
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ func (c Command) Run(args []string, additionalArgs []string) {
AbortWithUsage(err.Error())
}
for _, arg := range args {
if strings.HasPrefix(arg, "-") {
if len(arg) > 1 && strings.HasPrefix(arg, "-") {
AbortWith(types.GinkgoErrors.FlagAfterPositionalParameter().Error())
}
}
4 changes: 2 additions & 2 deletions ginkgo/command/command_test.go
Original file line number Diff line number Diff line change
@@ -58,10 +58,10 @@ var _ = Describe("Command", func() {

Context("when flags parse", func() {
It("runs the command", func() {
c.Run([]string{"-contrabulaturally=16", "and-an-arg", "and-another"}, []string{"additional", "-args"})
c.Run([]string{"-contrabulaturally=16", "and-an-arg", "and-another", "-"}, []string{"additional", "-args"})
Ω(rt).Should(HaveRun("enflabulate"))

Ω(rt.DataFor("enflabulate")["Args"]).Should(Equal([]string{"and-an-arg", "and-another"}))
Ω(rt.DataFor("enflabulate")["Args"]).Should(Equal([]string{"and-an-arg", "and-another", "-"}))
Ω(rt.DataFor("enflabulate")["AdditionalArgs"]).Should(Equal([]string{"additional", "-args"}))

})
6 changes: 6 additions & 0 deletions ginkgo_t_dsl.go
Original file line number Diff line number Diff line change
@@ -130,6 +130,12 @@ type GinkgoTBWrapper struct {
func (g *GinkgoTBWrapper) Cleanup(f func()) {
g.GinkgoT.Cleanup(f)
}
func (g *GinkgoTBWrapper) Chdir(dir string) {
g.GinkgoT.Chdir(dir)
}
func (g *GinkgoTBWrapper) Context() context.Context {
return g.GinkgoT.Context()
}
func (g *GinkgoTBWrapper) Error(args ...any) {
g.GinkgoT.Error(args...)
}
Original file line number Diff line number Diff line change
@@ -16,7 +16,6 @@ func TestSymbolFixture(t *testing.T) {

var _ = It("prints out its symbols", func() {
cmd := exec.Command("go", "tool", "nm", "symbol_fixture.test")
output, err := cmd.CombinedOutput()
Expect(err).NotTo(HaveOccurred())
output, _ := cmd.CombinedOutput()
fmt.Println(string(output))
})
2 changes: 1 addition & 1 deletion types/version.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package types

const VERSION = "2.23.2"
const VERSION = "2.23.3"