# 1296 fix(precompiled test guite): exec bit check omitted on Windows (#1301)

jgrieger · jgriegershs · web-flow · commit 26eea013cbaf · 2023-11-10T06:29:22.000-07:00
Co-authored-by: Jacob Grieger &lt;jacob.grieger@siemens-healthineers.com&gt;
diff --git a/ginkgo/internal/test_suite.go b/ginkgo/internal/test_suite.go
@@ -7,6 +7,7 @@ import (
 	"path"
 	"path/filepath"
 	"regexp"
+	"runtime"
 	"strings"
 
 	"github.com/onsi/ginkgo/v2/types"
@@ -192,7 +193,7 @@ func precompiledTestSuite(path string) (TestSuite, error) {
 		return TestSuite{}, errors.New("this is not a .test binary")
 	}
 
-	if filepath.Ext(path) == ".test" && info.Mode()&0111 == 0 {
+	if filepath.Ext(path) == ".test" && runtime.GOOS != "windows" && info.Mode()&0111 == 0 {
 		return TestSuite{}, errors.New("this is not executable")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import (`
`7`	`7`	`"path"`
`8`	`8`	`"path/filepath"`
`9`	`9`	`"regexp"`
	`10`	`+ "runtime"`
`10`	`11`	`"strings"`
`11`	`12`
`12`	`13`	`"github.com/onsi/ginkgo/v2/types"`
`@@ -192,7 +193,7 @@ func precompiledTestSuite(path string) (TestSuite, error) {`
`192`	`193`	`return TestSuite{}, errors.New("this is not a .test binary")`
`193`	`194`	`}`
`194`	`195`
`195`		`- if filepath.Ext(path) == ".test" && info.Mode()&0111 == 0 {`
	`196`	`+ if filepath.Ext(path) == ".test" && runtime.GOOS != "windows" && info.Mode()&0111 == 0 {`
`196`	`197`	`return TestSuite{}, errors.New("this is not executable")`
`197`	`198`	`}`
`198`	`199`