Fix compile errors when comparing pointers. #699
Merged
+56
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #699 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 2 2
Lines 2127 2127
=======================================
Hits 1961 1961
Misses 166 166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thank you very much for your contribution! |
onqtam
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Explicitly convert pointer in `filldata<T*>::fill` * Add regression test * Increase standard compliance * Collect test output * Collect test output * Fix warnings * Add GCC workaround * Update doctest.h * Move __extension__ * Use different workaround * Add missing const qualifier Co-authored-by: Salvage <29021710+Saalvage@users.noreply.github.com>
moui0
added a commit
to moui0/archriscv-packages
that referenced
this pull request
Oct 11, 2023
Upstream merged: doctest/doctest#699
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Oct 11, 2023
Upstream merged: doctest/doctest#699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since v2.4.9, pointers comparison will trigger a compile error inside
doctestregarding pointer types. You can find reproduction examples and error messages in the issues referenced below.This PR fixes that problem.
GitHub Issues
Fixes #665, Fixes #675, Fixes #686